From 67440844c422ee30b31df9a46a7f99ac0e833add Mon Sep 17 00:00:00 2001
From: Guilhem Moulin <guilhem@fripost.org>
Date: Sat, 9 Nov 2019 03:13:45 +0100
Subject: Refactor and improve test suite.

---
 tests/run | 173 ++++++++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 113 insertions(+), 60 deletions(-)

(limited to 'tests/run')

diff --git a/tests/run b/tests/run
index ee11757..cb52518 100755
--- a/tests/run
+++ b/tests/run
@@ -22,27 +22,27 @@ set -ue
 PATH=/usr/bin:/bin
 export PATH
 
-if [ $# -ne 1 ]; then
-    printf "Usage: %s TESTNAME\\n" "$0" >&2
+if [ $# -eq 0 ] || [ $# -gt 2 ]; then
+    printf "Usage: %s TESTFILE [TESTNAME]\\n" "$0" >&2
     exit 1
 fi
 
-TEST="${1%/}"
-TEST="${TEST##*/}"
-NAME="${TEST#[0-9]*-}"
-TESTDIR="$(dirname -- "$0")/$TEST"
+TESTDIR="$(dirname -- "$0")/$1"
+TESTNAME="${2-$1}"
 if [ ! -d "$TESTDIR" ]; then
     printf "ERROR: Not a directory: %s\\n" "$TESTDIR" >&2
     exit 1
 fi
 
-ROOTDIR="$(mktemp --tmpdir="${TMPDIR:-/dev/shm}" --directory "$NAME.XXXXXXXXXX")"
+ROOTDIR="$(mktemp --tmpdir="${TMPDIR:-/dev/shm}" --directory "$1.XXXXXXXXXX")"
 trap 'rm -rf -- "$ROOTDIR"' EXIT INT TERM
 
-STDOUT="$ROOTDIR/stdout"
-STDERR="$ROOTDIR/stderr"
+_STDOUT="$ROOTDIR/stdout"
+_STDERR="$ROOTDIR/stderr"
 TMPDIR="$ROOTDIR/tmp"
+STDERR="$(mktemp --tmpdir="$ROOTDIR" "stderr.XXXXXXXXXX")"
 mkdir -- "$TMPDIR" "$ROOTDIR/home"
+declare -a REMOTES=()
 
 # Set environment for the given user
 environ_set() {
@@ -60,24 +60,35 @@ environ_set() {
 # Prepare the test harness
 prepare() {
     declare -a ENVIRON=()
-    local src cfg target u home
+    local src cfg target u home n capability
+    if [ -f "$TESTDIR/remotes" ]; then
+        for cfg in $(seq 1 "$(< "$TESTDIR/remotes")"); do
+            REMOTES+=( "remote$cfg" )
+        done
+    else
+        REMOTES+=( "remote" )
+    fi
     # copy dovecot config
-    for src in "$TESTDIR/local.conf" "$TESTDIR"/remote*.conf; do
-        [ -r "$src" ] || continue
-        u="${src#"$TESTDIR/"}"
-        u="${u%.conf}"
-        home="$ROOTDIR/home/$u"
+    for u in "local" "${REMOTES[@]}"; do
+        home="$ROOTDIR/$u/home"
         export "HOME_$u"="$home"
-        mkdir -pm0755 -- "$home/.local/bin"
         mkdir -pm0700 -- "$home/.config/dovecot"
         cat >"$home/.config/dovecot/config" <<-EOF
-			log_path = /dev/null
-			mail_home = $ROOTDIR/home/%u
+			log_path = $HOME_local/mail.log
+			mail_home = $home
+			mail_location = dbox:~/inbox:LAYOUT=index
 			mailbox_list_index = yes
 			ssl = no
+			namespace inbox {
+			    inbox = yes
+			}
 		EOF
-        cat >>"$home/.config/dovecot/config" <"$src"
+        if [ -f "$TESTDIR/$u.conf" ]; then
+            cat >>"$home/.config/dovecot/config" <"$TESTDIR/$u.conf"
+        fi
+
         environ_set "$u"
+        mkdir -pm0755 -- "$home/.local/bin"
         cat >"$home/.local/bin/doveadm" <<-EOF
 			#!/bin/sh
 			exec env -i ${ENVIRON[@]@Q} \\
@@ -89,36 +100,62 @@ prepare() {
     # copy interimap config
     mkdir -pm0700 -- "$HOME_local/.local/share/interimap"
     mkdir -pm0700 -- "$HOME_local/.config/interimap"
-    for cfg in "$TESTDIR"/remote*.conf; do
-        cfg="${cfg#"$TESTDIR/remote"}"
-        cfg="${cfg%.conf}"
-        u="remote$cfg"
+    for u in "${REMOTES[@]}"; do
+        n="${u#remote}"
         eval home="\$HOME_$u"
-        if [ -f "$TESTDIR/interimap.conf" ]; then
-            cat <"$TESTDIR/interimap.conf" >>"$HOME_local/.config/interimap/config$cfg"
-        fi
-        cat >>"$HOME_local/.config/interimap/config$cfg" <<-EOF
+
+        cat >>"$HOME_local/.config/interimap/config$n" <<-EOF
 			database = $u.db
- 
+			#logfile = $HOME_local/interimap$n.log
+		EOF
+        if [ -f "$TESTDIR/interimap$n.conf" ]; then
+            cat <"$TESTDIR/interimap$n.conf" >>"$HOME_local/.config/interimap/config$n"
+        fi
+
+        cat >>"$HOME_local/.config/interimap/config$n" <<-EOF
+
 			[local]
 			type = tunnel
 			command = exec ${HOME_local@Q}/.local/bin/doveadm exec imap
 			null-stderr = NO
+		EOF
+        if [ -f "$TESTDIR/interimap$n.local" ]; then
+            cat <"$TESTDIR/interimap$n.local" >>"$HOME_local/.config/interimap/config$n"
+        fi
+
+        # `doveadm exec imap` ignores 'imap_capability' from doveconf/config
+        capability="$(doveconf -c "$home/.config/dovecot/config" -h imap_capability)"
+        cat >>"$HOME_local/.config/interimap/config$n" <<-EOF
 
 			[remote]
 			type = tunnel
-			command = exec ${home@Q}/.local/bin/doveadm exec imap
+			command = exec ${home@Q}/.local/bin/doveadm exec imap ${capability:+-oimap_capability=${capability@Q}}
 			null-stderr = NO
 		EOF
+        if [ -f "$TESTDIR/interimap$n.remote" ]; then
+            cat <"$TESTDIR/interimap$n.remote" >>"$HOME_local/.config/interimap/config$n"
+        fi
     done
 }
 prepare
 
 # Wrappers for interimap(1) and doveadm(1)
 interimap() {
-    declare -a ENVIRON=()
+    declare -a ENVIRON=() r=0
     environ_set "local"
-    env -i "${ENVIRON[@]}" perl -I./lib -T ./interimap "$@"
+    env -i "${ENVIRON[@]}" perl -I./lib -T ./interimap "$@" 2>"$STDERR" || r=$?
+    cat "$STDERR" >&2
+    return $r
+}
+interimap_init() {
+    local u="${1-remote}"
+    local db="$XDG_DATA_HOME/interimap/$u.db"
+    local cfg="config${u#remote}"
+
+    test \! -e "$db"          || error "Database already exists" 1
+    interimap --config "$cfg" || error "Couldn't initialize interimap" 1
+    test -f "$db"             || error "Database is still missing" 1
+    grep -Fx "Creating new schema in database file $db" <"$STDERR" || error "DB wasn't created" 1
 }
 doveadm() {
     if [ $# -le 2 ] || [ "$1" != "-u" ]; then
@@ -167,9 +204,7 @@ dump_test_result() {
     local above="<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<"
     local src u home
     declare -a ENVIRON=()
-    for src in "$TESTDIR/local.conf" "$TESTDIR"/remote*.conf; do
-        u="${src#"$TESTDIR/"}"
-        u="${u%.conf}"
+    for u in "local" "${REMOTES[@]}"; do
         environ_set "$u"
         eval home="\$HOME_$u"
         printf "%s dovecot configuration:\\n%s\\n" "$u" "$below"
@@ -177,16 +212,18 @@ dump_test_result() {
         printf "%s\\n\\n" "$above"
     done
 
-    printf "(local) interimap configuration:\\n%s\\n" "$below"
-    cat <"$HOME_local/.config/interimap/config"
-    printf "%s\\n\\n" "$above"
+    for u in "${REMOTES[@]}"; do
+        printf "interimap configuration (local <-> $u):\\n%s\\n" "$below"
+        cat <"$HOME_local/.config/interimap/config${u#remote}"
+        printf "%s\\n\\n" "$above"
+    done
 
-    printf "standard output was:\\n%s\\n" "$below"
-    cat <"$STDOUT"
+    printf "standard output:\\n%s\\n" "$below"
+    cat <"$_STDOUT"
     printf "%s\\n\\n" "$above"
 
-    printf "standard error was:\\n%s\\n" "$below"
-    cat <"$STDERR"
+    printf "standard error:\\n%s\\n" "$below"
+    cat <"$_STDERR"
     printf "%s\\n\\n" "$above"
 }
 
@@ -225,7 +262,7 @@ check_mailbox_status2() {
 			WHERE mailbox = $blob
 		EOF
     )
-    check_mailbox_status_values "local" "$lmailbox"  $lUIDVALIDITY $lUIDNEXT $lHIGHESTMODSEQ $MESSAGES
+    check_mailbox_status_values "local" "$lmailbox" $lUIDVALIDITY $lUIDNEXT $lHIGHESTMODSEQ $MESSAGES
     check_mailbox_status_values "$u"    "$rmailbox" $rUIDVALIDITY $rUIDNEXT $rHIGHESTMODSEQ $MESSAGES
 
     local a b
@@ -304,38 +341,54 @@ check_mailbox_list() {
         <( printf "%s" "${lmailboxes[*]}" | sort ) <( printf "%s" "${rmailboxes[*]}" | sort )
 }
 
-# Wrappers for grep(1) and `grep -C`
-xgrep() {
-    if ! grep -q "$@"; then
-        printf "\`grep %s\` failed on line %d\\n" "${*@Q}" ${BASH_LINENO[0]} >&2
-        exit 1
-    fi
-}
+# Wrapper for `grep -c`
 xcgrep() {
     local m="$1" n
     shift
     if ! n="$(grep -c "$@")" || [ $m -ne $n ]; then
-        printf "\`grep -c %s\` failed on line %d: %d != %d\\n" "${*@Q}" ${BASH_LINENO[0]} "$m" "$n" >&2
-        exit 1
+        error "\`grep -c ${*@Q}\` failed ($m != $n)" 1
     fi
 }
+error() {
+    local err="${1+": $1"}" i=${2-0}
+    printf "ERROR$err on file %s line %d\\n" "${BASH_SOURCE[i+1]}" ${BASH_LINENO[i]} >&2
+    exit 1
+}
+ptree_abort() {
+    local pid
+    for pid in "$@"; do
+        # kill a process and its children
+        pkill -TERM -P "$pid" || printf "pkill(1) exited with status %d\\n" "$?" >&2
+        kill  -TERM    "$pid" || printf  "kill(1) exited with status %d\\n" "$?" >&2
+    done
+    wait
+}
+step_start() { printf "%s%s..." "${INDENT-}" "$1" >&3; }
+step_done() { passed >&3; }
+failed() {
+    [ -t 1 ] && printf " \\x1B[1;31mFAILED\\x1B[0m\\n" || echo " FAILED"
+}
+passed() {
+    [ -t 1 ] && printf " \\x1B[1;32mPASSED\\x1B[0m\\n" || echo " PASSED"
+}
 
 # Run test in a sub-shell
 declare -a ENVIRON=()
 environ_set "local"
-export TMPDIR TESTDIR STDOUT STDERR "${ENVIRON[@]}"
+export TMPDIR TESTDIR STDERR "${ENVIRON[@]}"
 export -f environ_set doveadm interimap sqlite3 sample_message deliver
+export -f interimap_init ptree_abort step_start step_done passed
 export -f check_mailbox_status check_mailbox_status_values check_mailbox_status2
-export -f check_mailboxes_status check_mailbox_list xgrep xcgrep
-printf "%s..." "$TEST"
-if ! bash -ue "$TESTDIR/run" >"$STDOUT" 2>"$STDERR"; then
-    echo " FAILED"
-    dump_test_result
+export -f check_mailboxes_status check_mailbox_list xcgrep error
+[ "$TESTNAME" = "..." ] || printf "%s%s..." "${INDENT-}" "$TESTNAME"
+if ! bash -ue "$TESTDIR/t" 3>&1 >"$_STDOUT" 2>"$_STDERR"; then
+    failed
+    [ "${QUIET-n}" = "y" ] || dump_test_result
     exit 1
 else
-    echo " OK"
-    if grep -Paq "\\x00" -- "$STDOUT" "$STDERR"; then
-        printf "\\tWarn: binary output (outstanding \\0)!\\n"
+    [ "$TESTNAME" = "..." ] || passed
+    if grep -Paq "\\x00" -- "$_STDOUT" "$_STDERR"; then
+        printf "\\tWARN: binary output (outstanding \\0)!\\n"
     fi
     exit 0
 fi
-- 
cgit v1.2.3


From 78522acced782587b3768f3fb57f2f25cb905754 Mon Sep 17 00:00:00 2001
From: Guilhem Moulin <guilhem@fripost.org>
Date: Sun, 10 Nov 2019 03:18:26 +0100
Subject: Test suite: add new tests for authentication.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This can't be done with `doveadm exec imap`, so the IMAPd needs to bind
to TCP port 10143 on the loopback interface.

Also, no longer pass ‘imap_capability’ Dovecot setting explicitely to
`doveadm exec imap`; changed tests/sync-live-crippled to use type=imap
instead of type=tunnel.
---
 tests/run | 109 +++++++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 83 insertions(+), 26 deletions(-)

(limited to 'tests/run')

diff --git a/tests/run b/tests/run
index cb52518..bff9c18 100755
--- a/tests/run
+++ b/tests/run
@@ -27,7 +27,8 @@ if [ $# -eq 0 ] || [ $# -gt 2 ]; then
     exit 1
 fi
 
-TESTDIR="$(dirname -- "$0")/$1"
+BASEDIR="$(dirname -- "$0")"
+TESTDIR="$BASEDIR/$1"
 TESTNAME="${2-$1}"
 if [ ! -d "$TESTDIR" ]; then
     printf "ERROR: Not a directory: %s\\n" "$TESTDIR" >&2
@@ -35,7 +36,18 @@ if [ ! -d "$TESTDIR" ]; then
 fi
 
 ROOTDIR="$(mktemp --tmpdir="${TMPDIR:-/dev/shm}" --directory "$1.XXXXXXXXXX")"
-trap 'rm -rf -- "$ROOTDIR"' EXIT INT TERM
+declare -a DOVECOT_SERVER=()
+trap cleanup EXIT INT TERM
+cleanup() {
+    local pid c
+    for c in "${DOVECOT_SERVER[@]}"; do
+        if [ ! -f "$c" ] || ! env -i PATH="/usr/bin:/bin" doveadm -c "$c" stop; then
+            pid="$(< "${c%/*}/run/master.pid")"
+            kill -TERM "$pid" || printf "kill(1) exited with status %d\\n" "$?" >&2
+        fi
+    done
+    rm -rf -- "$ROOTDIR"
+}
 
 _STDOUT="$ROOTDIR/stdout"
 _STDERR="$ROOTDIR/stderr"
@@ -60,7 +72,7 @@ environ_set() {
 # Prepare the test harness
 prepare() {
     declare -a ENVIRON=()
-    local src cfg target u home n capability
+    local src cfg target u home n proto
     if [ -f "$TESTDIR/remotes" ]; then
         for cfg in $(seq 1 "$(< "$TESTDIR/remotes")"); do
             REMOTES+=( "remote$cfg" )
@@ -72,27 +84,64 @@ prepare() {
     for u in "local" "${REMOTES[@]}"; do
         home="$ROOTDIR/$u/home"
         export "HOME_$u"="$home"
-        mkdir -pm0700 -- "$home/.config/dovecot"
-        cat >"$home/.config/dovecot/config" <<-EOF
+        environ_set "$u"
+
+        mkdir -pm0700 -- "$home/.dovecot"
+        cat >"$home/.dovecot/config" <<-EOF
 			log_path = $HOME_local/mail.log
 			mail_home = $home
 			mail_location = dbox:~/inbox:LAYOUT=index
 			mailbox_list_index = yes
 			ssl = no
+			listen = 127.0.0.1, ::1
 			namespace inbox {
 			    inbox = yes
 			}
 		EOF
         if [ -f "$TESTDIR/$u.conf" ]; then
-            cat >>"$home/.config/dovecot/config" <"$TESTDIR/$u.conf"
+            cat >>"$home/.dovecot/config" <"$TESTDIR/$u.conf"
+        fi
+        cp -aT -- "$BASEDIR/snippets/dovecot" "$home/.dovecot/conf.d"
+
+        proto="$(env -i "${ENVIRON[@]}" doveconf -c "$home/.dovecot/config" -h protocols)"
+        if [ -n "$proto" ]; then
+            cat >>"$home/.dovecot/config" <<-EOF
+				# https://wiki.dovecot.org/HowTo/Rootless
+				base_dir = $home/.dovecot/run
+				default_internal_user  = $(id -un)
+				default_internal_group = $(id -gn)
+				default_login_user     = $(id -un)
+
+				service anvil {
+				    chroot =
+				}
+				service imap-login {
+				    chroot =
+				}
+				service stats {
+				    chroot =
+				}
+
+				passdb {
+				    args = scheme=PLAIN username_format=%u $home/.dovecot/users
+				    driver = passwd-file
+				}
+				userdb {
+				    args = username_format=%u $home/.dovecot/users
+				    driver = passwd-file
+				}
+			EOF
+
+            env -i PATH="/usr/bin:/bin" /usr/sbin/dovecot -c "$home/.dovecot/config"
+            DOVECOT_SERVER+=( "$home/.dovecot/config" )
+            printf "%s:%s:::::\\n" "$u" "$(xxd -l16 -p </dev/urandom)" >"$home/.dovecot/users"
         fi
 
-        environ_set "$u"
         mkdir -pm0755 -- "$home/.local/bin"
         cat >"$home/.local/bin/doveadm" <<-EOF
 			#!/bin/sh
 			exec env -i ${ENVIRON[@]@Q} \\
-			    doveadm -c ${home@Q}/.config/dovecot/config "\$@"
+			    doveadm -c ${home@Q}/.dovecot/config "\$@"
 		EOF
         chmod +x -- "$home/.local/bin/doveadm"
     done
@@ -123,15 +172,19 @@ prepare() {
             cat <"$TESTDIR/interimap$n.local" >>"$HOME_local/.config/interimap/config$n"
         fi
 
-        # `doveadm exec imap` ignores 'imap_capability' from doveconf/config
-        capability="$(doveconf -c "$home/.config/dovecot/config" -h imap_capability)"
-        cat >>"$HOME_local/.config/interimap/config$n" <<-EOF
-
-			[remote]
-			type = tunnel
-			command = exec ${home@Q}/.local/bin/doveadm exec imap ${capability:+-oimap_capability=${capability@Q}}
-			null-stderr = NO
-		EOF
+        printf "\\n[remote]\\n" >>"$HOME_local/.config/interimap/config$n"
+        if [ -s "$home/.dovecot/users" ]; then
+            cat <<-EOF
+				username = $u
+				password = $(awk -F: -vu="$u" '$1 == u {print $2}' <"$home/.dovecot/users")
+			EOF
+        else
+            cat <<-EOF
+				type = tunnel
+				command = exec ${home@Q}/.local/bin/doveadm exec imap
+				null-stderr = NO
+			EOF
+        fi >>"$HOME_local/.config/interimap/config$n"
         if [ -f "$TESTDIR/interimap$n.remote" ]; then
             cat <"$TESTDIR/interimap$n.remote" >>"$HOME_local/.config/interimap/config$n"
         fi
@@ -208,7 +261,7 @@ dump_test_result() {
         environ_set "$u"
         eval home="\$HOME_$u"
         printf "%s dovecot configuration:\\n%s\\n" "$u" "$below"
-        env -i "${ENVIRON[@]}" doveconf -c "$home/.config/dovecot/config" -n
+        env -i "${ENVIRON[@]}" doveconf -c "$home/.dovecot/config" -n
         printf "%s\\n\\n" "$above"
     done
 
@@ -218,6 +271,10 @@ dump_test_result() {
         printf "%s\\n\\n" "$above"
     done
 
+    printf "mail.log:\\n%s\\n" "$below"
+    cat -- "$HOME_local/mail.log" 2>/dev/null || true
+    printf "%s\\n\\n" "$above"
+
     printf "standard output:\\n%s\\n" "$below"
     cat <"$_STDOUT"
     printf "%s\\n\\n" "$above"
@@ -230,10 +287,10 @@ dump_test_result() {
 # Check mailbox consistency between the local/remote server and interimap's database
 check_mailbox_status() {
     local mailbox="$1" lns="inbox" lsep lprefix rns="inbox" rsep rprefix
-    lsep="$(doveconf -c "$HOME_local/.config/dovecot/config" -h "namespace/$lns/separator")"
-    lprefix="$(doveconf -c "$HOME_local/.config/dovecot/config" -h "namespace/$lns/prefix")"
-    rsep="$(doveconf -c "$HOME_remote/.config/dovecot/config" -h "namespace/$lns/separator")"
-    rprefix="$(doveconf -c "$HOME_remote/.config/dovecot/config" -h "namespace/$lns/prefix")"
+    lsep="$(doveconf -c "$HOME_local/.dovecot/config" -h "namespace/$lns/separator")"
+    lprefix="$(doveconf -c "$HOME_local/.dovecot/config" -h "namespace/$lns/prefix")"
+    rsep="$(doveconf -c "$HOME_remote/.dovecot/config" -h "namespace/$lns/separator")"
+    rprefix="$(doveconf -c "$HOME_remote/.dovecot/config" -h "namespace/$lns/prefix")"
 
     local blob="x'$(printf "%s" "$mailbox" | tr "$lsep" "\\0" | xxd -c256 -ps)'"
     local rmailbox="$(printf "%s" "$mailbox" | tr "$lsep" "$rsep")"
@@ -305,10 +362,10 @@ check_mailboxes_status() {
 # Check mailbox list constency between the local and remote servers
 check_mailbox_list() {
     local m i lns="inbox" lsep lprefix rns="inbox" rsep rprefix sub=
-    lsep="$(doveconf -c "$HOME_local/.config/dovecot/config" -h "namespace/$lns/separator")"
-    lprefix="$(doveconf -c "$HOME_local/.config/dovecot/config" -h "namespace/$lns/prefix")"
-    rsep="$(doveconf -c "$HOME_remote/.config/dovecot/config" -h "namespace/$lns/separator")"
-    rprefix="$(doveconf -c "$HOME_remote/.config/dovecot/config" -h "namespace/$lns/prefix")"
+    lsep="$(doveconf -c "$HOME_local/.dovecot/config" -h "namespace/$lns/separator")"
+    lprefix="$(doveconf -c "$HOME_local/.dovecot/config" -h "namespace/$lns/prefix")"
+    rsep="$(doveconf -c "$HOME_remote/.dovecot/config" -h "namespace/$lns/separator")"
+    rprefix="$(doveconf -c "$HOME_remote/.dovecot/config" -h "namespace/$lns/prefix")"
     if [ $# -gt 0 ] && [ "$1" = "-s" ]; then
         sub="-s"
         shift
-- 
cgit v1.2.3


From b7514eeac609a7e99c66031f853f695bb82c990a Mon Sep 17 00:00:00 2001
From: Guilhem Moulin <guilhem@fripost.org>
Date: Sun, 10 Nov 2019 18:11:05 +0100
Subject: Test suite: don't treat broken symlinks as missing.

`test -f` deferences paths so fails on broken symlinks, yielding an
incorrect test environment and perhaps even a false negative.
---
 tests/run | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'tests/run')

diff --git a/tests/run b/tests/run
index bff9c18..2903938 100755
--- a/tests/run
+++ b/tests/run
@@ -73,7 +73,7 @@ environ_set() {
 prepare() {
     declare -a ENVIRON=()
     local src cfg target u home n proto
-    if [ -f "$TESTDIR/remotes" ]; then
+    if [ -f "$TESTDIR/remotes" ] || [ -L "$TESTDIR/remotes" ]; then
         for cfg in $(seq 1 "$(< "$TESTDIR/remotes")"); do
             REMOTES+=( "remote$cfg" )
         done
@@ -98,7 +98,7 @@ prepare() {
 			    inbox = yes
 			}
 		EOF
-        if [ -f "$TESTDIR/$u.conf" ]; then
+        if [ -f "$TESTDIR/$u.conf" ] || [ -L "$TESTDIR/$u.conf" ]; then
             cat >>"$home/.dovecot/config" <"$TESTDIR/$u.conf"
         fi
         cp -aT -- "$BASEDIR/snippets/dovecot" "$home/.dovecot/conf.d"
@@ -157,7 +157,7 @@ prepare() {
 			database = $u.db
 			#logfile = $HOME_local/interimap$n.log
 		EOF
-        if [ -f "$TESTDIR/interimap$n.conf" ]; then
+        if [ -f "$TESTDIR/interimap$n.conf" ] || [ -L "$TESTDIR/interimap$n.conf" ]; then
             cat <"$TESTDIR/interimap$n.conf" >>"$HOME_local/.config/interimap/config$n"
         fi
 
@@ -168,7 +168,7 @@ prepare() {
 			command = exec ${HOME_local@Q}/.local/bin/doveadm exec imap
 			null-stderr = NO
 		EOF
-        if [ -f "$TESTDIR/interimap$n.local" ]; then
+        if [ -f "$TESTDIR/interimap$n.local" ] || [ -L "$TESTDIR/interimap$n.local" ]; then
             cat <"$TESTDIR/interimap$n.local" >>"$HOME_local/.config/interimap/config$n"
         fi
 
@@ -185,7 +185,7 @@ prepare() {
 				null-stderr = NO
 			EOF
         fi >>"$HOME_local/.config/interimap/config$n"
-        if [ -f "$TESTDIR/interimap$n.remote" ]; then
+        if [ -f "$TESTDIR/interimap$n.remote" ] || [ -L "$TESTDIR/interimap$n.remote" ]; then
             cat <"$TESTDIR/interimap$n.remote" >>"$HOME_local/.config/interimap/config$n"
         fi
     done
-- 
cgit v1.2.3


From dac4ab1c9306bf2035bc1547d2ed27ab09850120 Mon Sep 17 00:00:00 2001
From: Guilhem Moulin <guilhem@fripost.org>
Date: Wed, 13 Nov 2019 04:16:48 +0100
Subject: Test suite: add new test for pullimap(1).

This adds a dependency on Dovecot's LMTPd, which will bind to
to TCP port 10024 on the loopback interface.
---
 tests/run | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)

(limited to 'tests/run')

diff --git a/tests/run b/tests/run
index 2903938..30d20f9 100755
--- a/tests/run
+++ b/tests/run
@@ -146,9 +146,10 @@ prepare() {
         chmod +x -- "$home/.local/bin/doveadm"
     done
 
-    # copy interimap config
-    mkdir -pm0700 -- "$HOME_local/.local/share/interimap"
-    mkdir -pm0700 -- "$HOME_local/.config/interimap"
+    # copy interimap and pullimap configuration
+    mkdir -pm0700 -- "$HOME_local/.local/share/interimap" "$HOME_local/.local/share/pullimap"
+    mkdir -pm0700 -- "$HOME_local/.config/interimap"      "$HOME_local/.config/pullimap"
+    echo "deliver-rcpt = local" >>"$HOME_local/.config/pullimap/config"
     for u in "${REMOTES[@]}"; do
         n="${u#remote}"
         eval home="\$HOME_$u"
@@ -160,6 +161,9 @@ prepare() {
         if [ -f "$TESTDIR/interimap$n.conf" ] || [ -L "$TESTDIR/interimap$n.conf" ]; then
             cat <"$TESTDIR/interimap$n.conf" >>"$HOME_local/.config/interimap/config$n"
         fi
+        if [ -f "$TESTDIR/pullimap.conf" ] || [ -L "$TESTDIR/pullimap.conf" ]; then
+            cat <"$TESTDIR/pullimap.conf" >>"$HOME_local/.config/pullimap/config"
+        fi
 
         cat >>"$HOME_local/.config/interimap/config$n" <<-EOF
 
@@ -172,7 +176,6 @@ prepare() {
             cat <"$TESTDIR/interimap$n.local" >>"$HOME_local/.config/interimap/config$n"
         fi
 
-        printf "\\n[remote]\\n" >>"$HOME_local/.config/interimap/config$n"
         if [ -s "$home/.dovecot/users" ]; then
             cat <<-EOF
 				username = $u
@@ -184,21 +187,26 @@ prepare() {
 				command = exec ${home@Q}/.local/bin/doveadm exec imap
 				null-stderr = NO
 			EOF
-        fi >>"$HOME_local/.config/interimap/config$n"
+        fi >"$HOME_local/.$u.conf"
         if [ -f "$TESTDIR/interimap$n.remote" ] || [ -L "$TESTDIR/interimap$n.remote" ]; then
-            cat <"$TESTDIR/interimap$n.remote" >>"$HOME_local/.config/interimap/config$n"
+            cat <"$TESTDIR/interimap$n.remote" >>"$HOME_local/.$u.conf"
         fi
+
+        { printf "\\n[remote]\\n";  cat <"$HOME_local/.$u.conf"; } >>"$HOME_local/.config/interimap/config$n"
+        { printf "\\n[%s]\\n" "$u"; cat <"$HOME_local/.$u.conf"; } >>"$HOME_local/.config/pullimap/config"
     done
 }
 prepare
 
 # Wrappers for interimap(1) and doveadm(1)
-interimap() {
+interimap() { _interimap_cmd "interimap" "$@"; }
+pullimap()  { _interimap_cmd "pullimap"  "$@"; }
+_interimap_cmd() {
     declare -a ENVIRON=() r=0
+    local script="$1"
+    shift
     environ_set "local"
-    env -i "${ENVIRON[@]}" perl -I./lib -T ./interimap "$@" 2>"$STDERR" || r=$?
-    cat "$STDERR" >&2
-    return $r
+    env -i "${ENVIRON[@]}" perl -I./lib -T "./$script" "$@" 2> >(tee "$STDERR" >&2)
 }
 interimap_init() {
     local u="${1-remote}"
@@ -227,8 +235,10 @@ sqlite3() {
 # Sample (random) message
 sample_message() {
     local date="$(date +"%s.%N")"
+    # also try non-conventional addresses for pullimap
+    local sender="$(shuf -n1 -e "sender" "first.last" "foo-bar" \"\" "\"x\\\" #&\\\\y\"" )"
     cat <<-EOF
-		From: <sender@example.net>
+		From: <$sender@example.net>
 		To: <recipient@example.net>
 		Date: $(date -R -d@"$date")
 		Message-ID: <$date@example.net>
@@ -240,7 +250,7 @@ sample_message() {
 
 # Wrapper for dovecot-lda(1)
 deliver() {
-    local -a argv
+    declare -a argv
     while [ $# -gt 0 ] && [ "$1" != "--" ]; do
         argv+=( "$1" )
         shift
@@ -433,8 +443,8 @@ passed() {
 declare -a ENVIRON=()
 environ_set "local"
 export TMPDIR TESTDIR STDERR "${ENVIRON[@]}"
-export -f environ_set doveadm interimap sqlite3 sample_message deliver
-export -f interimap_init ptree_abort step_start step_done passed
+export -f environ_set doveadm interimap interimap_init pullimap _interimap_cmd
+export -f sqlite3 sample_message deliver ptree_abort step_start step_done passed
 export -f check_mailbox_status check_mailbox_status_values check_mailbox_status2
 export -f check_mailboxes_status check_mailbox_list xcgrep error
 [ "$TESTNAME" = "..." ] || printf "%s%s..." "${INDENT-}" "$TESTNAME"
-- 
cgit v1.2.3