Email de-obfuscation: Use a custom "data-mailto-b64" attribute.HEADmaster

Rather than an href.  This avoids validators complaining that the href
value is invalid.

2 files changed, 9 insertions, 7 deletions

diff --git a/index.html b/index.html
index b3a8748..1522c6a 100644
--- a/index.html
+++ b/index.html
@@ -47,7 +47,8 @@
               </li>
             </ul>
             <p class="small text-muted info-credits">Webbkartan är utvecklad av
-              <a href="mailto:Z3VpbGhlbQ __AT__ ZnJpcG9zdA __DOT__ b3Jn" target="_blank" class="email-address-b64">Guilhem Moulin</a> på uppdrag av
+              <a data-mailto-b64="Z3VpbGhlbQ __AT__ ZnJpcG9zdA __DOT__ b3Jn" href="#" target="_blank" class="email-address-b64">Guilhem Moulin</a>
+              på uppdrag av
               <a href="https://www.klimatanalysnorr.se" target="_blank">Klimatanalys Norr projektet</a>.</p>
           </div>
         </div>
@@ -187,7 +188,7 @@
 
             <h3>Buggrapporter och feedback</h3>
             <p>Tveka inte att skicka ett
-            <a href="mailto:Z3VpbGhlbQ __AT__ ZnJpcG9zdA __DOT__ b3Jn" target="_blank" class="link-secondary email-address-b64">mejl
+            <a data-mailto-b64="Z3VpbGhlbQ __AT__ ZnJpcG9zdA __DOT__ b3Jn" href="#" target="_blank" class="link-secondary email-address-b64">mejl
               <i class="bi bi-envelope-at"></i></a>
             med önskemål, buggrapporter, förslag till
             förbättring med flera.
diff --git a/main.js b/main.js
index 93edd14..9840746 100644
--- a/main.js
+++ b/main.js
@@ -483,12 +483,12 @@ if (window.location === window.parent.location) {
     };
 
     /* de-obfuscate email address */
-    const MAILTO = 'mailto:';
     const CLASSNAME = 'email-address-b64';
+    const ATTRNAME = 'data-mailto-b64';
     for (const a of panel.getElementsByClassName(CLASSNAME)) {
-      if (a.tagName.toLowerCase() === 'a' && a.href.toLowerCase().startsWith(MAILTO)) {
-        let href = MAILTO;
-        for (const part of a.href.substr(MAILTO.length).split(/\s+/)) {
+      if (a.tagName.toLowerCase() === 'a' && a.hasAttribute(ATTRNAME)) {
+        let href = 'mailto:';
+        for (const part of a.getAttribute(ATTRNAME).split(/\s+/)) {
           switch (part) {
             case '__AT__':
               href += '@';
@@ -500,8 +500,9 @@ if (window.location === window.parent.location) {
               href += atob(part);
           }
         }
-        a.href = href;
         a.classList.remove(CLASSNAME);
+        a.removeAttribute(ATTRNAME);
+        a.href = href;
       }
     }